NF: uses NoteId instead of Long #11984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's used upstream. It was defined in notes.py, but since Notes.java may not get converted, consts is the most relevant place to put it. Those ones were found by searching for "nodeId: Long", "NoteId: Long" and "nid: Long".
lukstbit
approved these changes
Aug 14, 2022
lukstbit
added
the
Needs Second Approval
david-allison
approved these changes
Aug 14, 2022
github-actions
bot
removed
the
Needs Second Approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's used upstream. It was defined in notes.py, but since Notes.java may not get
converted, consts is the most relevant place to put it.
Those ones were found by searching for "nodeId: Long", "NoteId: Long" and "nid:
Long".